fix: windows adaptor was failing to load #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #40
What was the problem/requirement? (What/Why)
There were a few problems with using C4D on windows:
ModuleNotFoundError: No module named 'win32file'
NameError: name 'main' is not defined. Did you mean: 'min'?
since we were catching the above errorWhat was the solution? (How)
HTTPClientInterface
to the OS-agnosticClientInterface
to work on both Linux and Windows.What is the impact of this change?
You can render on Windows!
How was this change tested?
The adaptor was also able to successfully render a job
Was this change documented?
Yup!
Is this a breaking change?
Nope!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.